-
Notifications
You must be signed in to change notification settings - Fork 84
Add location filter to request manager filter bar #7132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile OverviewGreptile SummaryThis PR adds location filtering functionality to the new privacy request manager screen. The implementation cleanly integrates a location filter into the existing filter bar infrastructure. Key changes:
The implementation follows existing patterns in the codebase and properly handles URL state synchronization, making filters persistent across page reloads. Confidence Score: 5/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 files reviewed, no comments
jpople
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, working as expected for me!
Ticket ENG-1910
Description Of Changes
Adds a location filter option in the new request manager screen. Adds an option to the location select to display both country and country/region options.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works