Skip to content

Conversation

@lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Dec 16, 2025

Ticket ENG-1910

Description Of Changes

Adds a location filter option in the new request manager screen. Adds an option to the location select to display both country and country/region options.

Code Changes

Steps to Confirm

  1. Visit preview link and enable the feature flag "Privacy request v2"
  2. Go to new privacy request screen
  3. Check a location filter is shown after the request type filter
  4. Check the location filter shows both country/state options, as well as country only options
  5. Apply a location filter, check it filters the results and update the url too. Reload the page and check the filter is still applied and shown. Clear the filter.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Dec 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Dec 16, 2025 4:36pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
fides-privacy-center Ignored Ignored Dec 16, 2025 4:36pm

@lucanovera lucanovera marked this pull request as ready for review December 16, 2025 17:46
@lucanovera lucanovera requested a review from a team as a code owner December 16, 2025 17:46
@lucanovera lucanovera requested review from jpople and removed request for a team December 16, 2025 17:46
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 16, 2025

Greptile Overview

Greptile Summary

This PR adds location filtering functionality to the new privacy request manager screen. The implementation cleanly integrates a location filter into the existing filter bar infrastructure.

Key changes:

  • Extended usePrivacyRequestsFilters hook to manage location filter state with URL synchronization
  • Added LocationSelect component to the filter bar UI positioned after the request type filter
  • Enhanced LocationSelect component with includeCountryOnlyOptions prop to display both country-only (e.g., "US") and country/region combinations (e.g., "US-CA")
  • Backend already supports location filtering via PrivacyRequestFilter.location with proper normalization

The implementation follows existing patterns in the codebase and properly handles URL state synchronization, making filters persistent across page reloads.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The implementation is clean, follows established patterns, and integrates seamlessly with existing infrastructure. The backend already supports location filtering, so this is purely a frontend enhancement. The changes are localized to filter management and UI components without touching core business logic. Type safety is maintained throughout, and the implementation properly handles null values and state synchronization.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
clients/admin-ui/src/features/privacy-requests/dashboard/hooks/usePrivacyRequestsFilters.ts 5/5 Added location filter to URL query state management with proper integration into existing filter logic
clients/admin-ui/src/features/privacy-requests/dashboard/PrivacyRequestFiltersBar.tsx 5/5 Added LocationSelect component to filter bar with proper handler and state management
clients/fidesui/src/components/data-entry/LocationSelect.tsx 5/5 Enhanced component to support country-only options alongside country/region combinations

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, working as expected for me!

@lucanovera lucanovera added this pull request to the merge queue Dec 17, 2025
Merged via the queue into main with commit 3c9a244 Dec 17, 2025
47 checks passed
@lucanovera lucanovera deleted the ENG-1910-Add-location-option-to-filter-bar branch December 17, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants