-
Notifications
You must be signed in to change notification settings - Fork 84
Added reusable animation components to FidesUI #7125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
b46941e to
a5a3e99
Compare
Greptile OverviewGreptile SummaryThis PR successfully migrates from Important Files Changed
Confidence score: 4/5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
clients/admin-ui/src/features/data-discovery-and-detection/action-center/MonitorResult.tsx, line 47 (link)style: Dead code:
showSkeletonis still in the interface (line 47), destructured (line 53), and used (line 112), but is no longer passed from the parent component. Consider removing completely if skeleton loading is intentionally removed.
13 files reviewed, 3 comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
13 files reviewed, 1 comment
50dcb3a to
27a73a1
Compare
lucanovera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The animation and message look great! Properly implemented animations with the new library. Approved!
Ticket ENG-2154
Description Of Changes
Migrated from
framer-motiontomotionpackage and added two reusable animation components to fidesui:ExitGridandExpandCollapse. These components provide smooth animations for the Action Center UI, specifically for the confidence level cards and expandable rows.Loom demo
Code Changes
motionpackage (v12.23.26) in fidesuiExitGridcomponent for grid items with exit animations (slide up and fade out when removed)ExpandCollapsecomponent for smooth height and opacity transitionsframer-motionusage with newExpandCollapsecomponent inMonitorResultConfidenceRowto useExitGridinstead of Ant List for better animation supportDiscovery Monitor Resultsto invalidation tagsSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works