Skip to content

Conversation

@speaker-ender
Copy link
Contributor

@speaker-ender speaker-ender commented Dec 12, 2025

Ticket ENG-2038

Description Of Changes

Only displays system info in resource drawer when the value exists

Code Changes

  • Conditionally adding the system object to the items prop of the Descriptions component in the resource details drawer when a value exists.

Steps to Confirm

  1. Navigate to a monitor tree view screen in the Action Center.
  2. Open the resource details drawer by clicking on list items.
  3. Confirm that the System row doesn't display when a value is not given from the BE.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Dec 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Dec 16, 2025 2:29am
1 Skipped Deployment
Project Deployment Review Updated (UTC)
fides-privacy-center Ignored Ignored Dec 16, 2025 2:29am

@speaker-ender speaker-ender marked this pull request as ready for review December 12, 2025 15:57
@speaker-ender speaker-ender requested a review from a team as a code owner December 12, 2025 15:57
@speaker-ender speaker-ender requested review from jpople and removed request for a team December 12, 2025 15:57
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 12, 2025

Greptile Overview

Greptile Summary

Fixed the System field in the resource details drawer to only display when a system_key value exists, replacing the previous behavior that would show the row with a boolean false value as children when no system was assigned.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a straightforward UI improvement that uses proper conditional rendering to hide empty fields. The implementation uses the spread operator correctly to conditionally include the system row only when system_key exists and is truthy, which prevents displaying incorrect boolean values in the UI.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/ResourceDetailsDrawer.tsx 5/5 Conditionally includes system field in descriptions when system_key exists, preventing display of empty/false values

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@speaker-ender speaker-ender added this pull request to the merge queue Dec 16, 2025
Merged via the queue into main with commit 8b96122 Dec 16, 2025
47 checks passed
@speaker-ender speaker-ender deleted the feat/conditional-system-in-resource-details branch December 16, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants