Skip to content

Conversation

@johnewart
Copy link
Collaborator

Appears to be causing an issue with test cleanup in some cases, leading to random late failures.

Will re-add once I figure out why it's happening / mitigate the issue.

Appears to be causing an issue with test cleanup in some cases, leading
to random late failures.

This reverts commit 6310fab.
@johnewart johnewart requested a review from a team as a code owner December 4, 2025 21:40
@vercel
Copy link

vercel bot commented Dec 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ignored Ignored Dec 4, 2025 9:40pm
fides-privacy-center Ignored Ignored Dec 4, 2025 9:40pm

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 4, 2025

Greptile Overview

Greptile Summary

This PR cleanly reverts the HTTP health check feature that was added in PR #7067, which was causing test cleanup issues and random late failures. The revert removes the vendored celery-healthcheck code and restores the original celery-based health checks.

Changes reverted:

  • Removed HTTP health check server implementation (celery_healthcheck module)
  • Removed healthcheck_port and healthcheck_ping_timeout configuration settings
  • Restored original docker-compose worker configurations with celery inspect-based health checks
  • Removed HTTP endpoint exposure (port 9001) from workers

The revert is complete and thorough - all references to the HTTP health check feature have been removed, and the codebase returns to its previous stable state.

Confidence Score: 5/5

  • This PR is safe to merge - it's a clean revert that restores proven stable functionality
  • Perfect score because this is a complete and correct revert of a problematic feature. All traces of the HTTP health check have been removed, configuration is cleaned up, and the system returns to the previously working celery inspect-based health checks. No code quality issues or incomplete reversions detected.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
docker-compose.yml 5/5 Reverts HTTP health check changes, restoring original celery health check and removing worker-other service extension pattern
src/fides/api/tasks/init.py 5/5 Removes health check server registration and config parameters from celery app initialization
src/fides/config/celery_settings.py 5/5 Removed healthcheck_port and healthcheck_ping_timeout configuration fields

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@johnewart johnewart enabled auto-merge December 4, 2025 21:49
@johnewart johnewart added this pull request to the merge queue Dec 4, 2025
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.28%. Comparing base (0149de4) to head (ed48f5d).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7077      +/-   ##
==========================================
+ Coverage   87.25%   87.28%   +0.03%     
==========================================
  Files         532      530       -2     
  Lines       34897    34858      -39     
  Branches     4037     4036       -1     
==========================================
- Hits        30448    30426      -22     
+ Misses       3567     3550      -17     
  Partials      882      882              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged via the queue into main with commit 04356c4 Dec 4, 2025
69 checks passed
@johnewart johnewart deleted the johnewart/revert-celery-http-healthcheck branch December 4, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants