-
Notifications
You must be signed in to change notification settings - Fork 84
ENG-2140 Add token_type to oauth/token response #7074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Greptile OverviewGreptile SummaryAdded the required
Confidence Score: 5/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 1 comment
| token_type = json.loads(response.text).get("token_type") | ||
| assert token_type == "Bearer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider adding similar token_type assertions to user login and invite acceptance tests in test_user_endpoints.py, since UserLoginResponse also contains the AccessToken schema
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7074 +/- ##
=======================================
Coverage 87.24% 87.25%
=======================================
Files 532 532
Lines 34900 34897 -3
Branches 4036 4037 +1
=======================================
Hits 30448 30448
+ Misses 3570 3567 -3
Partials 882 882 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ticket ENG-2140
Description Of Changes
Partial implementation of ENG-2140. Adds the required
token_type: "Bearer"field to our/api/oauth/tokenendpoint response so that it is compliant with the standard.Steps to Confirm
token_typeis returnedPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works