Skip to content

Conversation

@gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Dec 3, 2025

Description Of Changes

Fix confidence bucket filter options to display in logical order (High → Medium → Low → Manual) instead of alphabetically from the server. Also fix Ant Progress component text width being hardcoded to 2em.

Code Changes

  • Add CONFIDENCE_BUCKET_ORDER constant and sort logic for confidence bucket filters
  • Add SCSS override for .ant-progress-steps .ant-progress-text width

Steps to Confirm

  1. Navigate to Action Center fields view
  2. Verify confidence bucket filter options appear in order: High, Medium, Low, Manual
  3. Verify progress component text displays properly without fixed width constraint
CleanShot 2025-12-03 at 14 42 56@2x

@vercel
Copy link

vercel bot commented Dec 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ready Ready Preview Comment Dec 3, 2025 10:21pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
fides-privacy-center Ignored Ignored Dec 3, 2025 10:21pm

@gilluminate gilluminate marked this pull request as ready for review December 3, 2025 21:47
@gilluminate gilluminate requested a review from a team as a code owner December 3, 2025 21:47
@gilluminate gilluminate requested review from jpople and speaker-ender and removed request for a team and jpople December 3, 2025 21:47
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 3, 2025

Greptile Overview

Greptile Summary

This PR fixes two UI issues in the Action Center:

Confidence Bucket Filter Order

  • Adds CONFIDENCE_BUCKET_ORDER constant to define the logical display order (High → Medium → Low → Manual)
  • Sorts confidence buckets after filtering to override the alphabetical order returned by the server
  • The implementation correctly uses Array.indexOf() for sorting based on the predefined order

Progress Component Text Width

  • Overrides Ant Design's hardcoded 2em width for progress step text with width: auto
  • Improves SCSS organization by nesting the progress-related styles using the & selector
  • Preserves existing rounded border-radius styling

Both changes are focused, minimal, and address specific UI problems without introducing unnecessary complexity.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are straightforward UI fixes with no complex logic, no security implications, and no backend changes. The confidence bucket ordering uses a simple, clear constant-based approach, and the SCSS change is a minimal CSS override that improves layout. Both changes are well-scoped and directly address the stated problems.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/MonitorFieldFilters.tsx 5/5 Added CONFIDENCE_BUCKET_ORDER constant and sort logic to display confidence buckets in logical order (High → Medium → Low → Manual) instead of alphabetically
clients/fidesui/src/ant-theme/global.scss 5/5 Fixed Ant Progress component text width by overriding hardcoded 2em width with auto, improved SCSS structure with nested selectors

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@speaker-ender speaker-ender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Small code nit but not a blocker

@gilluminate gilluminate force-pushed the gill/action-center-fixes branch from 10ac7c1 to f3d49e3 Compare December 3, 2025 22:19
@gilluminate gilluminate enabled auto-merge December 3, 2025 22:21
@gilluminate gilluminate added this pull request to the merge queue Dec 3, 2025
Merged via the queue into main with commit c4e780f Dec 3, 2025
47 checks passed
@gilluminate gilluminate deleted the gill/action-center-fixes branch December 3, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants