-
Notifications
You must be signed in to change notification settings - Fork 84
Fix Action Center confidence bucket order and progress text width #7073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile OverviewGreptile SummaryThis PR fixes two UI issues in the Action Center: Confidence Bucket Filter Order
Progress Component Text Width
Both changes are focused, minimal, and address specific UI problems without introducing unnecessary complexity. Confidence Score: 5/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, no comments
speaker-ender
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Small code nit but not a blocker
...in-ui/src/features/data-discovery-and-detection/action-center/fields/MonitorFieldFilters.tsx
Outdated
Show resolved
Hide resolved
10ac7c1 to
f3d49e3
Compare
Description Of Changes
Fix confidence bucket filter options to display in logical order (High → Medium → Low → Manual) instead of alphabetically from the server. Also fix Ant Progress component text width being hardcoded to
2em.Code Changes
CONFIDENCE_BUCKET_ORDERconstant and sort logic for confidence bucket filters.ant-progress-steps .ant-progress-textwidthSteps to Confirm