Skip to content

Conversation

@lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Dec 3, 2025

Ticket ENG-1829

Description Of Changes

Fixes the pagination issue in the Integrations page by giving the appropriate total count.

Code Changes

  • Changed total count in pagination config to use the correct variable

Steps to Confirm

  1. Visit the preview link and login with nightly credentials
  2. Change pagination size to 10
  3. Confirm pagination appears and you can change pages

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@lucanovera lucanovera requested a review from a team as a code owner December 3, 2025 15:00
@lucanovera lucanovera requested review from jpople and removed request for a team December 3, 2025 15:00
@vercel
Copy link

vercel bot commented Dec 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ready Ready Preview Comment Dec 3, 2025 8:20pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
fides-privacy-center Ignored Ignored Dec 3, 2025 8:20pm

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 3, 2025

Greptile Overview

Greptile Summary

This PR fixes a pagination bug on the Integrations page where the total count was incorrectly set to tableData.length (the number of items on the current page) instead of data?.total (the server-provided total count of all items).

  • Root cause: Using tableData.length for the pagination total meant the table only knew about items on the current page, causing pagination controls to malfunction or not appear when more items existed across pages.
  • Fix: Changed to use data?.total from the API response, which correctly represents the total count of all integrations across all pages.
  • Pattern consistency: This fix aligns with the established pattern used in other parts of the codebase (e.g., useDigestConfigList.tsx, useInProgressMonitorTasksList.tsx) for server-side pagination.

Confidence Score: 5/5

  • This is a simple, low-risk one-line fix that corrects a clear pagination bug with no side effects.
  • The change is minimal (single property value change), uses an established pattern from the codebase, and the fix logic is straightforward and correct. The data?.total pattern handles the loading state gracefully via optional chaining.
  • No files require special attention.

Important Files Changed

File Analysis

Filename Score Overview
clients/admin-ui/src/pages/integrations/index.tsx 5/5 Fixed pagination total count from tableData.length (current page items only) to data?.total (server-provided total), matching the standard pattern used elsewhere in the codebase.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@lucanovera lucanovera enabled auto-merge December 3, 2025 20:16
@lucanovera lucanovera added this pull request to the merge queue Dec 3, 2025
Merged via the queue into main with commit 3e7ff66 Dec 3, 2025
47 checks passed
@lucanovera lucanovera deleted the ENG-1829-Pagination-is-broken-on-the-Integrations-page branch December 3, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants