-
Notifications
You must be signed in to change notification settings - Fork 84
ENG-2116 Update privacy notice sandbox to use new API schema #7057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile OverviewGreptile SummaryUpdated frontend types and privacy notice sandbox implementation to align with breaking changes in consent v3 API schema.
Confidence Score: 4/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6 files reviewed, 1 comment
| ? UserConsentPreference.OPT_IN | ||
| : UserConsentPreference.OPT_OUT, | ||
| experience_config_history_id: experienceConfigHistoryId, | ||
| collected_at: new Date().toISOString(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Verify backend accepts ISO 8601 with Z suffix - previous code used +00:00 format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does, I changed it
Ticket ENG-2116
Description Of Changes
In ENG-2116 we made some breaking changes to the consent v3 schemas, namely:
collected_atis now a top-level field on the preference object rather than being nested undermeta.fidesexperience_config_history_idis now a nested field undermeta.fidesrather than a top-level fieldCode Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works