-
Notifications
You must be signed in to change notification settings - Fork 84
Support request data as criteria for manual task conditions #7054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support request data as criteria for manual task conditions #7054
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile OverviewGreptile SummaryThis PR adds support for using privacy request data as criteria for manual task conditions. Users can now select between dataset fields and privacy request fields (like Key changes:
The implementation includes an allowlist of privacy request fields to prevent overwhelming users with too many options. The code follows existing patterns but contains some Confidence Score: 4/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7 files reviewed, 3 comments
clients/admin-ui/src/features/integrations/configure-tasks/utils.ts
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/integrations/configure-tasks/utils.ts
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/integrations/configure-tasks/AddConditionForm.tsx
Outdated
Show resolved
Hide resolved
…rt-Request-Data-as-criteria-for-manual-task-conditions
.../admin-ui/src/features/integrations/configure-tasks/components/PrivacyRequestFieldPicker.tsx
Outdated
Show resolved
Hide resolved
| {isEditing | ||
| ? "Update the condition settings for task creation." | ||
| : "Configure a new condition that must be met before a task is created. Select a field from your datasets to create the condition."} | ||
| : "Configure a new condition that must be met before a task is created. Select a field from your datasets or from the privacy request to create the condition."} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great catch, I've just updated that part to check for the flag
|
@gilluminate Thanks for the review! I've added the flag check for the text and removed the style prop. It's now ready for a re-review when you have the time. |
6c5d7f4 to
f2376e7
Compare
gilluminate
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!

Ticket ENG-2014
Description Of Changes
Basic support for using request data as manual task conditions behind an alpha feature flag.
This is the first PR that implements the fields. There will be followup PRs to add custom pickers (location, policy, etc), restricting opeators (only list operators on list fields, etc) and supporting custom fields.
Code Changes
Steps to Confirm
Privacy request field" option
Note: Currently there is no filtering for valid conditions depending on the field selected, and the value input is always text. There will be a followup PR for those improvements.
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works