Skip to content

Conversation

@stephenkiers
Copy link
Contributor

RE: https://github.com/ethyca/fides/actions/runs/19719977625/job/56500500100

Description Of Changes

This failed on me. I am attempting a fix.

Code Changes

Steps to Confirm

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@stephenkiers stephenkiers requested a review from a team as a code owner November 27, 2025 00:42
@stephenkiers stephenkiers requested review from speaker-ender and removed request for a team November 27, 2025 00:42
@vercel
Copy link

vercel bot commented Nov 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ignored Ignored Nov 27, 2025 0:42am
fides-privacy-center Ignored Ignored Nov 27, 2025 0:42am

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 27, 2025

Greptile Overview

Greptile Summary

Fixes a flaky Cypress test by adding an explicit wait for the complete task modal to fully close before attempting to open a second modal.

  • Added cy.get('[data-testid="complete-task-modal"]').should("not.exist") assertion after closing first modal (line 442-443)
  • Prevents race condition where the second modal click could occur before the first modal's closing animation completes
  • Standard pattern for handling sequential modal interactions in Cypress tests

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a single-line test fix that addresses a clear race condition in a Cypress test. It uses standard Cypress best practices for sequential modal testing and doesn't modify any production code.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
clients/privacy-center/cypress/e2e/privacy-center/external-manual-tasks.cy.ts 5/5 Adds explicit wait for modal close before opening next modal to fix flaky test timing issue

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@stephenkiers stephenkiers added this pull request to the merge queue Nov 27, 2025
Merged via the queue into main with commit 10c208b Nov 27, 2025
43 checks passed
@stephenkiers stephenkiers deleted the fix-flaky-test branch November 27, 2025 20:22
jjdaurora pushed a commit that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants