[ENG-1759]

[JadeCara]

Ticket ENG-1759

Description Of Changes

🎯 All emails related to manual tasks can be edited in the message templates UI, except the welcome email to the task portal. Can we make this email editable as well?

AC

• I can edit the subject and body of the “Welcome to our Privacy Center” from the Fides UI.

This PR adds the welcome email to the

Code Changes

• Updates to Front End elements:
  • Update testing count clients/admin-ui/cypress/e2e/messaging.cy.ts
  • clients/admin-ui/src/features/messaging-templates/CustomizableMessagingTemplatesEnum.ts
  • clients/admin-ui/src/features/messaging-templates/CustomizableMessagingTemplatesLabelEnum.ts
• Updates to BE
  • Updated the html src/fides/api/email_templates/templates/external_user_welcome.html
  • Added messaging template src/fides/api/models/messaging_template.py
  • Added to configurable templates src/fides/api/schemas/messaging/messaging.py
  • Updated dispatch to check for updates to template src/fides/api/service/messaging/message_dispatch_service.py
• Tests
  • Updated for flaky test: tests/ops/api/v1/endpoints/privacy_request/test_privacy_request_performance.py
  • Added test for template tests/ops/service/messaging/test_messaging_crud_service.py

Steps to Confirm

1. Run fidesplus pointed at this branch

2. Go to the notifications - External User Welcome will now be one of the options

3. You can click on it and edit it then save it

4. To test the send go to integrations and create a manual task and hit manage - under Manual Tasks you can create an external user. Create one for yourself.

5. This will automatically kick off an email to you - verify the updated text has changed and there are no placeholders in the message (the link locally doesnt actually point at anything)

Pre-Merge Checklist

• Issue requirements met
• All CI pipelines succeeded
• CHANGELOG.md updated
  • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
  • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Updates unreleased work already in Changelog, no new entry necessary
• UX feedback:
  • All UX related changes have been reviewed by a designer
  • No UX review needed
• Followup issues:
  • Followup issues created
  • No followup issues
• Database migrations:
  • Ensure that your downrev is up to date with the latest revision on main
  • Ensure that your downgrade() migration is correct and works
    • If a downgrade migration is not possible for this change, please call this out in the PR description!
  • No migrations
• Documentation:
  • Documentation complete, PR opened in fidesdocs
  • Documentation issue created in fidesdocs
  • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • No documentation updates required

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Preview	Comments	Updated (UTC)
fides-plus-nightly	Ignored	Preview		Nov 26, 2025 5:13pm
fides-privacy-center	Ignored			Nov 26, 2025 5:13pm

[codecov]

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.01%. Comparing base (c3fc2c6) to head (7f82d87).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
.../api/service/messaging/message_dispatch_service.py	0.00%	9 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7030      +/-   ##
==========================================
- Coverage   87.03%   87.01%   -0.03%     
==========================================
  Files         528      528              
  Lines       34668    34676       +8     
  Branches     4005     4008       +3     
==========================================
  Hits        30174    30174              
- Misses       3620     3628       +8     
  Partials      874      874              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[greptile-apps]

Greptile Overview

Greptile Summary

This PR successfully makes the External User Welcome email customizable through the messaging templates UI, following the existing pattern established for other configurable templates like Manual Task Digest.

Key changes:

• Added EXTERNAL_USER_WELCOME to the list of configurable messaging action types across frontend and backend
• Updated email template to support conditional rendering via custom_intro variable
• Modified message dispatch service to check for custom templates and render custom subject/body
• Added default template values with appropriate placeholders (__ORG_NAME__, __PORTAL_LINK__)
• Updated Cypress test count from 9 to 10 templates
• Fixed unrelated flaky performance test by mocking Celery task execution

The implementation is consistent with the existing MANUAL_TASK_DIGEST pattern, using the same approach of passing a custom_intro variable to conditionally replace default HTML content.

Confidence Score: 4/5

• This PR is safe to merge with minimal risk - changes follow established patterns and include appropriate test coverage
• The implementation correctly follows the existing pattern for customizable templates and includes proper test coverage. Score is 4 instead of 5 due to the template HTML readability issue noted in previous review comments (long default text on single line), though this doesn't affect functionality
• No files require special attention - all changes follow established patterns

Important Files Changed

File Analysis

Filename	Score	Overview
src/fides/api/email_templates/templates/external_user_welcome.html	4/5	Refactored template to support custom intro text via custom_intro variable with conditional rendering
src/fides/api/models/messaging_template.py	5/5	Added default template entry for EXTERNAL_USER_WELCOME with subject and body placeholders
src/fides/api/schemas/messaging/messaging.py	5/5	Added EXTERNAL_USER_WELCOME to CONFIGURABLE_MESSAGING_ACTION_TYPES tuple to enable UI customization
src/fides/api/service/messaging/message_dispatch_service.py	4/5	Added logic to check for custom template and render custom subject/body, passing custom_intro to HTML template

[greptile-apps]

_{9 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[JadeCara]

@greptile please review

[greptile-apps]

_{9 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[adamsachs]

👍

[gilluminate]

👍