Skip to content

Conversation

@gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Nov 20, 2025

Ticket ENG-1984

Description Of Changes

Fixed a bug where the Action Center field review was displaying raw data category keys instead of the user-friendly formatted names shown in the broader schema view.

Code Changes

  • Added custom label JSX to DataCategorySelect.tsx
  • Added title to preserve the value as title formatting that was used previously

Steps to Confirm

  1. Navigate to an Action Center Data Monitor result and open field details for review
  2. Add a category to one of the fields in the main list by clicking the [+]
  3. Click the name of the field to open the drawer
  4. Validate that the selected category is displayed the same way it is in the main list
CleanShot 2025-11-19 at 17 19 16@2x

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Nov 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ready Ready Preview Comment Nov 20, 2025 9:10pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
fides-privacy-center Ignored Ignored Nov 20, 2025 9:10pm

@gilluminate gilluminate marked this pull request as ready for review November 20, 2025 21:22
@gilluminate gilluminate requested a review from a team as a code owner November 20, 2025 21:22
@gilluminate gilluminate requested review from speaker-ender and removed request for a team November 20, 2025 21:22
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 20, 2025

Greptile Overview

Greptile Summary

Fixed the display bug where selected data categories showed raw fides keys (e.g., user.contact.email) instead of user-friendly formatted names. The fix adds a custom label JSX property that Ant Design's Select component uses to display the selected value, and a title property for tooltips showing the original key.

  • Added label property with formatted JSX (<strong>{primaryName || name}</strong> with optional secondary name) to match the dropdown display format
  • Added title property to preserve the raw fides_key value for tooltips

The implementation works correctly but bypasses TypeScript type safety since label and title aren't defined in the TaxonomySelectOption interface. This is allowed by the as never cast in TaxonomySelect.tsx:110.

Confidence Score: 4/5

  • This PR is safe to merge with minor type safety considerations
  • The fix correctly addresses the display bug and all CI checks passed. Score is 4 rather than 5 due to the type safety bypass (properties not in interface) and potential inconsistency with similar components like DataUseSelect that may need the same fix
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
clients/admin-ui/src/features/common/dropdown/DataCategorySelect.tsx 4/5 Added label JSX and title properties to fix selected category display, though these properties aren't in the TaxonomySelectOption interface

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@gilluminate gilluminate added this pull request to the merge queue Nov 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 25, 2025
@gilluminate gilluminate added this pull request to the merge queue Nov 25, 2025
Merged via the queue into main with commit 6e709c0 Nov 25, 2025
47 checks passed
@gilluminate gilluminate deleted the gill/ENG-1984/action-center-field branch November 25, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants