Skip to content

Add Windows instructions for access packages #7001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jpople merged 1 commit into from
Nov 19, 2025
Merged

Add Windows instructions for access packages #7001

jpople merged 1 commit into from
Nov 19, 2025
+2 −1

Conversation

@jpople
Copy link
Contributor

@jpople jpople commented Nov 19, 2025 •
edited by atlassian bot
Loading

Ticket ENG-1417

Description Of Changes

Updates copy in DSR access packages to specify that the package needs to be unzipped.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@jpople jpople requested a review from a team as a code owner November 19, 2025 14:57
@jpople jpople requested review from JadeCara and removed request for a team November 19, 2025 14:57
@vercel
Copy link

vercel bot commented Nov 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ignored Ignored Nov 19, 2025 2:57pm
fides-privacy-center Ignored Ignored Nov 19, 2025 2:57pm

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 19, 2025

Greptile Summary

  • Updated DSR access package instructions to explicitly tell users to unzip the archive before clicking sections
  • This clarifies the workflow for Windows users who may not automatically extract zip files

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Simple copy change to an HTML template with no logic modifications, security implications, or breaking changes
  • No files require special attention

greptile-apps[bot]
greptile-apps bot reviewed Nov 19, 2025
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

JadeCara
JadeCara approved these changes Nov 19, 2025
View reviewed changes
Copy link
Contributor

@JadeCara JadeCara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jpople jpople added this pull request to the merge queue Nov 19, 2025
Merged via the queue into main with commit e33ac5f Nov 19, 2025
41 checks passed
@jpople jpople deleted the jpople/eng-1417/windows-instructions branch November 19, 2025 16:26
jjdaurora pushed a commit that referenced this pull request Dec 5, 2025
@jpople @jjdaurora
Add Windows instructions for access packages (#7001)
c44443d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JadeCara JadeCara JadeCara approved these changes

+1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jpople @JadeCara