Skip to content

Conversation

@speaker-ender
Copy link
Contributor

@speaker-ender speaker-ender commented Nov 19, 2025

Ticket ENG-1928

Description Of Changes

Fixes bug where the "first" level of pagination wasn't triggering a request for the next set of results

Code Changes

  • Executing the function to find a parent node on the initial data before reducing

Steps to Confirm

  1. Visit the monitor fields screen with a dataset that contains more than 100 items at the first level of the tree
  2. Click the "Show more" button
  3. Confirm that it sends the request and populates the tree with the additional elements

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Nov 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ready Ready Preview Comment Nov 19, 2025 2:57pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
fides-privacy-center Ignored Ignored Nov 19, 2025 2:57pm

chore: linting

chore: update changelog
@speaker-ender speaker-ender force-pushed the fix/tree-pagination--ENG-1928 branch from ce0a6e7 to 9e94088 Compare November 19, 2025 14:53
@speaker-ender speaker-ender marked this pull request as ready for review November 19, 2025 14:53
@speaker-ender speaker-ender requested a review from a team as a code owner November 19, 2025 14:53
@speaker-ender speaker-ender requested review from jpople and removed request for a team November 19, 2025 14:53
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 19, 2025

Greptile Summary

  • Fixed bug where "Show more" button at the first level of the tree wasn't triggering pagination requests by ensuring parent node lookup checks the current data array before recursing into nested children
  • Updated recFindNodeParent function to call findNodeParent(data, key) before the reduce operation, enabling correct parent resolution for root-level pagination

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The fix is a small, targeted change that correctly addresses the pagination bug by adding a parent lookup at the current level before recursing. The logic is sound and the change is well-contained with no side effects.
  • No files require special attention

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

Copy link
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, confirmed issue is fixed.

@speaker-ender speaker-ender added this pull request to the merge queue Nov 19, 2025
Merged via the queue into main with commit 2583f79 Nov 19, 2025
47 checks passed
@speaker-ender speaker-ender deleted the fix/tree-pagination--ENG-1928 branch November 19, 2025 17:24
jjdaurora pushed a commit that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants