Skip to content

Conversation

@gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Nov 17, 2025

Ticket ENG-2002

Description Of Changes

Added a tooltip to the "GPC adaptive" banner option in the Privacy Experience form to clarify its conditional behavior for users.

Code Changes

  • Added tooltip to banner options field that appears when "Banner and modal" component type is selected
  • Tooltip explains that "GPC adaptive" shows acknowledge button when GPC is on, and opt in/opt out buttons when GPC is off

Steps to Confirm

  1. Navigate to Privacy Experience form in Admin UI
  2. Select "Banner and modal" as the component type
  3. Verify tooltip appears on the "Banner options" field
  4. Hover over the info icon to see the tooltip explaining GPC adaptive behavior
image

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Nov 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ready Ready Preview Comment Nov 17, 2025 11:14pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
fides-privacy-center Ignored Ignored Nov 17, 2025 11:14pm

@gilluminate gilluminate force-pushed the gill/ENG-2002/gpc-adaptive-setting-link-to branch from 430afaa to 6d8bc0e Compare November 17, 2025 23:04
@gilluminate gilluminate marked this pull request as ready for review November 17, 2025 23:04
@gilluminate gilluminate requested a review from a team as a code owner November 17, 2025 23:04
@gilluminate gilluminate requested review from jpople and removed request for a team November 17, 2025 23:04
@greptile-apps

This comment was marked as outdated.

greptile-apps[bot]

This comment was marked as outdated.

@gilluminate
Copy link
Contributor Author

@greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

@gilluminate gilluminate added this pull request to the merge queue Nov 18, 2025
Merged via the queue into main with commit 9c4107c Nov 18, 2025
47 checks passed
@gilluminate gilluminate deleted the gill/ENG-2002/gpc-adaptive-setting-link-to branch November 18, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants