Skip to content

Conversation

@gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Nov 17, 2025

Ticket ENG-1988

Description Of Changes

Set Ant Design Drawer zIndexPopupBase to 1300 to position it below Chakra modal overlays, enabling drawer contents to open modals without z-index conflicts.

Code Changes

  • Updated Ant theme configuration to set Drawer zIndexPopupBase to 1300

Steps to Confirm

  1. Go to data map report
  2. Click system name to open the drawer
  3. Expand the Sources accordion in the Data flow section near the bottom of the drawer
  4. Click Configure sources button
  5. Verify the modal appears above the drawer correctly

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Nov 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ready Ready Preview Comment Nov 17, 2025 9:28pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
fides-privacy-center Ignored Ignored Nov 17, 2025 9:28pm

@gilluminate gilluminate force-pushed the gill/ENG-1988/data-inventory-reporting branch from 1263902 to c8e7a5f Compare November 17, 2025 21:17
@gilluminate gilluminate marked this pull request as ready for review November 17, 2025 21:18
@gilluminate gilluminate requested a review from a team as a code owner November 17, 2025 21:18
@gilluminate gilluminate requested review from lucanovera and removed request for a team November 17, 2025 21:18
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 17, 2025

Greptile Summary

  • Fixed z-index conflict by setting Ant Design Drawer zIndexPopupBase to 1300, positioning it below Chakra modals (1400)
  • Updated CHANGELOG.md with entry under Developer Experience section

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk.
  • The change is a simple, focused z-index adjustment that solves a specific UI layering issue. The fix follows the established z-index hierarchy (Drawer at 1300, Chakra modal at 1400, other Ant popups at 1500), is well-documented with clear inline comments, and only affects the visual stacking order without changing any logic.
  • No files require special attention.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modal correctly appears above drawer. Approved!

Captura de pantalla 2025-11-18 a la(s) 11 26 10 a  m

@gilluminate gilluminate added this pull request to the merge queue Nov 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2025
@gilluminate gilluminate added this pull request to the merge queue Nov 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2025
@gilluminate gilluminate added this pull request to the merge queue Nov 18, 2025
Merged via the queue into main with commit 824d97b Nov 18, 2025
43 checks passed
@gilluminate gilluminate deleted the gill/ENG-1988/data-inventory-reporting branch November 18, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants