-
Notifications
You must be signed in to change notification settings - Fork 84
[ENG-1290] Conditional Deps Utils #6983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-1290] Conditional Deps Utils #6983
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (84.15%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## ENG-1290-convenience-fields #6983 +/- ##
===============================================================
+ Coverage 87.24% 87.26% +0.01%
===============================================================
Files 527 528 +1
Lines 34550 34651 +101
Branches 3988 4007 +19
===============================================================
+ Hits 30144 30238 +94
+ Misses 3536 3535 -1
- Partials 870 878 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Greptile Summary
Important Files Changed
Confidence score: 4/5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8 files reviewed, 1 comment
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
src/fides/api/task/conditional_dependencies/privacy_request/util.py
Outdated
Show resolved
Hide resolved
|
@greptile please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 2 comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
tests/api/task/conditional_dependencies/privacy_request/test_util.py
Outdated
Show resolved
Hide resolved
tests/api/task/conditional_dependencies/privacy_request/test_util.py
Outdated
Show resolved
Hide resolved
tests/api/task/conditional_dependencies/privacy_request/test_util.py
Outdated
Show resolved
Hide resolved
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, no comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
|
Moving this functionality to fidesplus, it makes more sense there. |
Ticket ENG-1290
Description Of Changes
🎯 As a user, I want to specify conditions that must be true to create manual tasks, which check the request data, so that I can create tasks conditionally based on data in the request.
This PR adds some utils required for adding privacy request conditional dependencies
Code Changes
src/fides/api/task/conditional_dependencies/privacy_request/util.pytests/api/task/conditional_dependencies/privacy_request/test_util.pySteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works