-
Notifications
You must be signed in to change notification settings - Fork 84
Replace restore hotkey with refresh hotkey in Action Center #6978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile OverviewGreptile SummaryThis PR replaces the "restore" (un-mute) hotkey with a "refresh" hotkey in the Action Center fields view, where pressing Key changes:
Issue found:
Confidence Score: 4/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7 files reviewed, 1 comment
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/page.tsx
Outdated
Show resolved
Hide resolved
…ion-center/fields/page.tsx Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
|
@gilluminate Everything looks good! But I wanted to clarify what you meant in steps 4 and 5? What does it mean to activate a field? The focused state? Also when clicking an item with the mouse the focus doesn't move. Finally, the keyboard actions are meant to happen only on the focused field and not the selected items (aka bulk action), right? |
|
@lucanovera I use the term "active" because it's not focused in the traditional browser focus sense, it's just the highlighted list item. Sorry, I should have been more clear, you have to click the title of the list item to activate it, not just an arbitrary spot. I've updated the steps for more clarity. |
lucanovera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Active state works as expected, new key action works, code changes look good. Approved!
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Ticket ENG-1946
Description Of Changes
Replaced the "restore" (un-mute) hotkey with a "refresh" hotkey in the Action Center fields view. The
rkey now refreshes the list instead of restoring/un-muting the active field.Remove the drawer's mask (bg overlay) when using keyboard navigation to see what's active beneath more easily.
Additionally, fixed keyboard navigation by syncing the active list item when clicking on a field after using keyboard navigation, preventing state mismatch between keyboard and mouse interactions.
Code Changes
UN_MUTEhotkey constant toREFRESHin field actionsuseFieldActionHotkeysto callonRefreshcallback instead ofhandleHotkeyAction(UN_MUTE)onRefreshCustomListHOC to exposesetActiveListItemIndexfunction throughonActiveItemChangecallbackpage.tsxto sync keyboard navigation active index with mouse clicksmask={!activeListItem}to ResourceDetailsDrawerscrollIntoView()and{ force: true }optionsSteps to Confirm
rkey and verify the field list refreshesris documented as "Refresh the list"Pre-Merge Checklist
CHANGELOG.mdupdated