-
Notifications
You must be signed in to change notification settings - Fork 84
Add API to run memory heap dump #6973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Greptile OverviewGreptile SummaryThis PR adds a new admin endpoint Key changes:
Confidence Score: 5/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6 files reviewed, no comments
adamsachs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the addition of an API invocation here seems reasonable to help make this more accessible 👍
| report_lines = [ | ||
| "", # Leading newline for visual separation | ||
| "=" * 80, | ||
| "MEMORY DUMP - THRESHOLD EXCEEDED", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch/tweak :)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6973 +/- ##
=======================================
Coverage 87.32% 87.33%
=======================================
Files 525 525
Lines 34445 34456 +11
Branches 3965 3966 +1
=======================================
+ Hits 30080 30091 +11
Misses 3501 3501
Partials 864 864 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No ticket
Description Of Changes
Adds a new endpoint
POST api/v1/admin/heap-dump(for owner roles only) to allow manually executing the exising_capture_heap_dumpfunction.Code Changes
Steps to Confirm
FIDES__EXECUTION__MEMORY_WATCHDOG_ENABLED=truePOST api/v1/admin/heap-dumpPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works