Skip to content

Conversation

@johnewart
Copy link
Collaborator

@johnewart johnewart commented Nov 14, 2025

Ticket ENG-1869

Description Of Changes

Adds work queues for import and export tasks for privacy preference documents

Code Changes

  • Add worker queue names and register them

Steps to Confirm

None

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@johnewart johnewart requested a review from a team as a code owner November 14, 2025 00:18
@vercel
Copy link

vercel bot commented Nov 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Nov 14, 2025 3:06am
fides-privacy-center Ignored Ignored Nov 14, 2025 3:06am

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 14, 2025

Greptile Overview

Greptile Summary

This PR adds infrastructure for two new Celery task queues: fides.privacy_request_exports and fides.privacy_request_ingestion. These queues are registered across the task system, cache monitoring, and worker initialization to support future import/export functionality for privacy preference documents.

  • Added PRIVACY_PREFERENCES_EXPORT_JOB_QUEUE_NAME and PRIVACY_PREFERENCES_INGESTION_JOB_QUEUE_NAME constants
  • Integrated new queues into queue count monitoring
  • Registered queues for worker consumption

The changes are straightforward infrastructure additions with no actual task implementations yet.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are purely additive infrastructure setup with no logic modifications. The new queue names follow existing patterns, are consistently applied across all necessary files, and don't affect any existing functionality. The only minor issue is missing explanatory comments, which is a style concern rather than a safety issue.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
src/fides/api/tasks/init.py 5/5 Added two new queue name constants for privacy preferences export and ingestion jobs
src/fides/api/util/cache.py 5/5 Imported new queue names and added them to queue count monitoring in get_queue_counts()
src/fides/api/worker/init.py 5/5 Imported new queue names and registered them in the worker's queue list for Celery consumption

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Comment on lines +22 to +23
PRIVACY_PREFERENCES_EXPORT_JOB_QUEUE_NAME = "fides.privacy_request_exports"
PRIVACY_PREFERENCES_INGESTION_JOB_QUEUE_NAME = "fides.privacy_request_ingestion"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: missing explanatory comments like other queue definitions have

@johnewart johnewart enabled auto-merge November 14, 2025 00:23
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.32%. Comparing base (8cb2833) to head (1f2df69).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6969      +/-   ##
==========================================
+ Coverage   87.30%   87.32%   +0.01%     
==========================================
  Files         524      525       +1     
  Lines       34383    34429      +46     
  Branches     3957     3962       +5     
==========================================
+ Hits        30018    30064      +46     
+ Misses       3505     3501       -4     
- Partials      860      864       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@johnewart johnewart changed the title Johnewart/privacy preferences export queue Add privacy preferences queues (ingestion and export) Nov 14, 2025
@johnewart johnewart added this pull request to the merge queue Nov 14, 2025
Merged via the queue into main with commit 7034e51 Nov 14, 2025
69 checks passed
@johnewart johnewart deleted the johnewart/privacy_preferences_export_queue branch November 14, 2025 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants