-
Notifications
You must be signed in to change notification settings - Fork 84
Update SearchInput component to use Ant Design #6968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6 files reviewed, no comments
355ee8f to
445cdac
Compare
df1e89b to
075e1cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
clients/admin-ui/src/features/common/DebouncedSearchInput.tsx, line 41 (link)syntax:
onClearprop removed from SearchInput but still referenced here - causes type error
12 files reviewed, 1 comment
jack-gale-ethyca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic
Ticket ENG-1979
Description Of Changes
Simplified the component by:
allowClearSpace.CompactwrapperwithIcon=trueas the defaultonClearCode Changes
SearchLineIconwith CarbonIcons.SearchSpace.Compactwrapper to singleInputcomponentwithIconto default totrue"Search..."to"Search"aria-label="Search"for accessibilitywithIconprop from two call sites where it's now the defaultSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works