-
Notifications
You must be signed in to change notification settings - Fork 84
Support GPC adaptive text templates in privacy experiences #6966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
567f990 to
ad38186
Compare
Greptile OverviewGreptile SummaryThis PR implements GPC-adaptive text templates in privacy experiences, allowing different text to be displayed based on whether Global Privacy Control is detected. The implementation is clean and well-tested, with comprehensive unit tests and E2E coverage. Key Changes:
Implementation Quality:
Confidence Score: 5/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10 files reviewed, no comments
751159e to
2ba2fa9
Compare
2ba2fa9 to
330c823
Compare
9586096 to
e2d52da
Compare
jpople
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix on the whitespace issue. Working as expected for me now!
Ticket ENG-1889
Description Of Changes
Add support for GPC-adaptive text templates in privacy experiences, allowing different text to be displayed based on whether Global Privacy Control (GPC) is detected.
Code Changes
gpc-utils.tswith conditional text processing logic using template markers (__GPC_START__,__GPC_END__,__NO_GPC_START__,__NO_GPC_END__)ConsentBanner.tsxandOverlay.tsxto process GPC conditionals in banner and modal textSteps to Confirm
"We value your privacy. __GPC_START__Your GPC signal has been detected.__GPC_END__")Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works