-
Notifications
You must be signed in to change notification settings - Fork 84
Add Ant messageContext to FidesUIProvider context #6934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
...n-ui/src/features/data-discovery-and-detection/action-center/fields/useFieldActionHotkeys.ts
Show resolved
Hide resolved
Greptile OverviewGreptile SummaryThis PR refactors the Ant Design message API to use a centralized context provider pattern. The Key changes:
Benefits:
Confidence Score: 5/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
42 files reviewed, no comments
…fides into jpople/2025-11-06/toasts
lucanovera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this developer improvements and updating the code everywhere. Code changes look good and the toasts work! I'll leave the approve and ask you just some small updates to make the PR complete: add DX entry in the changelog, update steps to reproduce with a way to test at least one of the toasts that was updated.
Description Of Changes
Adds messageContext to the FidesUIProvider so toasts are appropriately themed globally and the useMessage hook can be called more nicely.
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works