ENG-1826: initial updates to support headless privacy prefs #6901
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
adamsachs
left a comment
adamsachs
left a comment
There was a problem hiding this comment.
some notes on an initial commit here...
| existing_translation: Optional[ExperienceTranslation] = ( | ||
| self.get_translation_by_language(db, translation_data.get("language")) | ||
| ) |
There was a problem hiding this comment.
formatting fixes by our commit hook, sorry for the noise
| removed_regions: List[PrivacyNoticeRegion] = ( | ||
| [ # Regions that were not in the request, but currently attached to the Config | ||
| PrivacyNoticeRegion(reg) | ||
| for reg in {reg.value for reg in current_regions}.difference( | ||
| {reg.value for reg in regions} | ||
| ) | ||
| ] | ||
| ) |
There was a problem hiding this comment.
formatting, sorry for the noise
| experience_translations: List[ExperienceTranslation] = ( | ||
| privacy_experience_config.translations | ||
| ) |
| self.affected_system_status[system] = ( | ||
| status.name | ||
| ) # To avoid using "ExecutionLogStatus.paused" in the logs |
| banner_and_modal = "banner_and_modal" | ||
| api = "api" | ||
| tcf_overlay = "tcf_overlay" | ||
| headless = "headless" |
There was a problem hiding this comment.
the actual change!
| NOTE: updates here should be made accordingly to the privacy_preference.RequestOrigin enum, | ||
| as the values here can be saved in the privacy_preference.request_origin column. | ||
There was a problem hiding this comment.
in lieu of a more formal/proper way to couple these, just throwing a warning note here as a first line of defense against this happening again...
we could probably write a little test that compares them? :)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6901 +/- ##
=======================================
Coverage 87.47% 87.47%
=======================================
Files 523 523
Lines 34090 34091 +1
Branches 3917 3917
=======================================
+ Hits 29820 29821 +1
Misses 3414 3414
Partials 856 856 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
closing as we're doing #6902 instead |
Ticket []
Description Of Changes
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works