Skip to content

Conversation

@speaker-ender
Copy link
Contributor

@speaker-ender speaker-ender commented Oct 30, 2025

Ticket ENG-1757

Description Of Changes

Disables data category select component when the action is not available

Code Changes

Steps to Confirm

  1. Visit the new monitor fields screen
  2. Find a field that is in a state that should not allow modification of data categories
  3. Confirm that the select component does not allow selection

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@speaker-ender speaker-ender requested a review from a team as a code owner October 30, 2025 20:16
@vercel
Copy link

vercel bot commented Oct 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ready Ready Preview Comment Oct 30, 2025 8:18pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
fides-privacy-center Ignored Ignored Oct 30, 2025 8:18pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR adds logic to disable the data category select component when the ASSIGN_CATEGORIES action is not available for a field's resource status.

Key Changes:

  • Added dataCategoriesDisabled prop that threads through page.tsxMonitorFieldListItem.tsxClassificationSelect.tsx
  • Disables both the "Add" button and the select dropdown based on available actions for the field's diff_status
  • Logic correctly checks if ASSIGN_CATEGORIES is included in the AVAILABLE_ACTIONS for the resource's status (e.g., "Unlabeled" allows it, but "Confirmed" doesn't)

Minor Issue:

  • Inline style attribute used for disabled background styling (violates custom rule for style preferences)

Confidence Score: 4/5

  • This PR is safe to merge with only a minor style preference violation
  • The logic correctly implements the intended behavior by checking available actions per resource status. The only issue is a style preference violation using inline styles instead of Tailwind/CSS modules, which is non-critical and doesn't affect functionality.
  • ClassificationSelect.tsx has a minor inline style usage that could be refactored

Important Files Changed

File Analysis

Filename Score Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/ClassificationSelect.tsx 4/5 Added disabled prop to Button and inline style for disabled background. Style usage violates custom rule 3db03574.
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/MonitorFieldListItem.tsx 5/5 Added dataCategoriesDisabled parameter and passed to ClassificationSelect component - clean implementation.
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/page.tsx 4/5 Added logic to determine when data categories should be disabled based on available actions for the resource status.

3 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@speaker-ender speaker-ender changed the title fix: data category select actionable logic fix: data category select actionable logic [ENG-1757] Oct 30, 2025
Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@speaker-ender speaker-ender added this pull request to the merge queue Oct 30, 2025
Merged via the queue into main with commit b17dcbb Oct 30, 2025
46 checks passed
@speaker-ender speaker-ender deleted the fix/data-category-select-actionable-logic branch October 30, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants