-
Notifications
You must be signed in to change notification settings - Fork 84
hide categories that are not active #6892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
| const { getDataCategoryDisplayNameProps, getDataCategories } = | ||
| useTaxonomies(); | ||
| const dataCategories = getDataCategories(); | ||
| const dataCategories = getDataCategories().filter((c) => c.active); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Greptile Summary
This PR filters out inactive data categories from the classification select dropdown in the Data Discovery action center. The change ensures users only see and can select active data categories when classifying monitored fields.
Key changes:
- Added
.filter((c) => c.active)to the data categories returned bygetDataCategories()inClassificationSelect.tsx - This matches the pattern already used in
DataCategorySelect.tsxfor filtering active categories
Confidence Score: 5/5
- This PR is safe to merge with minimal risk
- The change is a simple, one-line filter that follows an existing pattern used elsewhere in the codebase (DataCategorySelect.tsx). The filter is defensive (handles undefined with optional chaining) and aligns with business requirements to hide inactive categories.
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/ClassificationSelect.tsx | 5/5 | Adds filtering to exclude inactive data categories from the classification dropdown |
1 file reviewed, no comments
Ticket ENG-1817
Description Of Changes
Filters inactive data categories from the classification select dropdown in the Data Discovery action center. This ensures only active data categories are available for selection when classifying monitored fields.
Code Changes
ClassificationSelect.tsxto filter data categories by active status before rendering optionsSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works