Skip to content

Conversation

@gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Oct 30, 2025

Ticket ENG-1817

Description Of Changes

Filters inactive data categories from the classification select dropdown in the Data Discovery action center. This ensures only active data categories are available for selection when classifying monitored fields.

Code Changes

  • Updated ClassificationSelect.tsx to filter data categories by active status before rendering options

Steps to Confirm

  1. Navigate to Data Discovery & Detection → Action Center
  2. Open the classification select dropdown on a monitored field
  3. Search for "System Data Automation Test" (if on Nightly)
  4. Confirm that inactive data category is not shown

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Oct 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ready Ready Preview Comment Oct 30, 2025 8:02pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
fides-privacy-center Ignored Ignored Oct 30, 2025 8:02pm

@gilluminate gilluminate marked this pull request as ready for review October 30, 2025 20:01
@gilluminate gilluminate requested a review from a team as a code owner October 30, 2025 20:01
const { getDataCategoryDisplayNameProps, getDataCategories } =
useTaxonomies();
const dataCategories = getDataCategories();
const dataCategories = getDataCategories().filter((c) => c.active);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR filters out inactive data categories from the classification select dropdown in the Data Discovery action center. The change ensures users only see and can select active data categories when classifying monitored fields.

Key changes:

  • Added .filter((c) => c.active) to the data categories returned by getDataCategories() in ClassificationSelect.tsx
  • This matches the pattern already used in DataCategorySelect.tsx for filtering active categories

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a simple, one-line filter that follows an existing pattern used elsewhere in the codebase (DataCategorySelect.tsx). The filter is defensive (handles undefined with optional chaining) and aligns with business requirements to hide inactive categories.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/ClassificationSelect.tsx 5/5 Adds filtering to exclude inactive data categories from the classification dropdown

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@gilluminate gilluminate added this pull request to the merge queue Oct 30, 2025
Merged via the queue into main with commit 1687ec8 Oct 30, 2025
46 checks passed
@gilluminate gilluminate deleted the gill/ENG-1817/inactive-data-categories-are branch October 30, 2025 20:25
adamsachs pushed a commit that referenced this pull request Oct 30, 2025
adamsachs pushed a commit that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants