Skip to content

fix(pushsync): cap overdraft backoff delay with jitter #5270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gacevicljubisa merged 3 commits into from
Nov 3, 2025
Merged

fix(pushsync): cap overdraft backoff delay with jitter #5270

gacevicljubisa merged 3 commits into from
Nov 3, 2025

Conversation

@gacevicljubisa
Copy link
Member

@gacevicljubisa gacevicljubisa commented Oct 30, 2025 •
edited
Loading

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Implements exponential backoff with jitter for overdraft balance refresh retries to reduce log spam and improve system resilience.

Changes:

  • Exponential backoff: Replace fixed 600ms delay with exponential backoff (1.2x multiplier, max 5s)
  • Jitter: Add ±10% random variation to prevent thundering herd effects
  • Reduced logging: Log first 3 attempts then every 5th attempt (1,2,3,6,11,16...)
  • Backoff reset: Reset delay when overdraft condition resolves

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

@gacevicljubisa gacevicljubisa linked an issue Oct 30, 2025 that may be closed by this pull request
Reduce overdraft balance refresh log spam with exponential backoff #5269
Closed
@gacevicljubisa gacevicljubisa requested a review from janos October 31, 2025 14:18
@gacevicljubisa gacevicljubisa merged commit 4ab44aa into master Nov 3, 2025
15 checks passed
@gacevicljubisa gacevicljubisa deleted the overdraft-backoff-delay branch November 3, 2025 09:33
@gacevicljubisa gacevicljubisa self-assigned this Nov 3, 2025
gacevicljubisa added a commit that referenced this pull request Nov 4, 2025
@gacevicljubisa
Revert "fix(pushsync): cap overdraft backoff delay with jitter (#5270)"
f397412 
This reverts commit 4ab44aa.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janos janos janos approved these changes

@martinconic martinconic martinconic approved these changes

@akrem-chabchoub akrem-chabchoub akrem-chabchoub approved these changes

Assignees

@gacevicljubisa gacevicljubisa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reduce overdraft balance refresh log spam with exponential backoff

5 participants

@gacevicljubisa @janos @martinconic @akrem-chabchoub