Skip to content

Conversation

@keeghcet
Copy link
Contributor

@keeghcet keeghcet commented Sep 8, 2025

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

replace for i := range b.N or for range b.N in a benchmark with for b.Loop(), and remove any preceding calls to b.StopTimer, b.StartTimer, and b.ResetTimer.

Supported by Go Team, more info: https://go.dev/blog/testing-b-loop

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

@martinconic
Copy link
Contributor

Please fix your commit msg as it is not according to our linter standard.

Signed-off-by: keeghcet <keeghcet@outlook.com>
@keeghcet keeghcet changed the title refactor: Use b.Loop() to simplify the code refactor: use b.Loop() to simplify the code Sep 9, 2025
@keeghcet
Copy link
Contributor Author

keeghcet commented Sep 9, 2025

Please fix your commit msg as it is not according to our linter standard.

Oh, Thanks. Please review again.

@martinconic martinconic merged commit cb09d3e into ethersphere:master Sep 10, 2025
15 checks passed
@bcsorvasi bcsorvasi added this to the v2.7.0 milestone Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants