Skip to content

Conversation

@jinjiadu
Copy link
Contributor

@jinjiadu jinjiadu commented May 24, 2025

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

In Go 1.21, the standard library includes built-in max/min function, which can greatly simplify the code.

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

@jinjiadu
Copy link
Contributor Author

jinjiadu commented Jun 5, 2025

Based on the error message, it seems that this issue is unrelated to the current modification.

--- FAIL: TestController_UpdateHandler (2.34s)
    --- FAIL: TestController_UpdateHandler/add_and_revoke_then_get_from_history (2.06s)
        controller_test.go:264: 
            	Error Trace:	/home/runner/work/bee/bee/pkg/accesscontrol/controller_test.go:264
            	Error:      	Received unexpected error:
            	            	access control: not found
            	Test:       	TestController_UpdateHandler/add_and_revoke_then_get_from_history
FAIL
FAIL	github.com/ethersphere/bee/v2/pkg/accesscontrol	2.552s

@gacevicljubisa
Copy link
Member

@jinjiadu can you merge master branch into yours and push to trigger the workflow that we can merge it? Or make some minor additional changes?

Signed-off-by: jinjiadu <jinjiadu@aliyun.com>
@jinjiadu
Copy link
Contributor Author

jinjiadu commented Sep 11, 2025

@jinjiadu can you merge master branch into yours and push to trigger the workflow that we can merge it? Or make some minor additional changes?

Thanks for your reply. @gacevicljubisa @nugaon @martinconic I have update the latest code. Please review again when you have time!

@gacevicljubisa gacevicljubisa merged commit 364fbc5 into ethersphere:master Sep 11, 2025
21 of 22 checks passed
@bcsorvasi bcsorvasi added this to the v2.7.0 milestone Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants