generate tx to claim + instant wds parameters#363
Open
vvalecha519 wants to merge 1 commit intomasterfrom
Open
Conversation
![chatgpt-codex-connector[bot]](https://waps.l3s.uni-hannover.de/live/im_/https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32cfb04146
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| withdrawRequestNFTInstance = WithdrawRequestNFT(addressProviderInstance.getContractAddress("WithdrawRequestNFT")); | ||
| liquifierInstance = Liquifier(payable(addressProviderInstance.getContractAddress("Liquifier"))); | ||
| etherFiTimelockInstance = EtherFiTimelock(payable(addressProviderInstance.getContractAddress("EtherFiTimelock"))); | ||
| etherFiTimelockInstance = EtherFiTimelock(payable(0xcD425f44758a08BaAB3C4908f3e3dE5776e45d7a)); |
There was a problem hiding this comment.
initializeRealisticFork now hardcodes etherFiTimelockInstance to the operating timelock instead of reading "EtherFiTimelock" from AddressProvider, which changes the authority model for every fork test that uses this setup. This makes _execute_timelock/_batch_execute_timelock impersonate the wrong proposer for contracts still governed by the main timelock (for example, mainnet role owners are pinned to 0x9f26... in test/behaviour-tests/ELExitsForkTestingDeployment.t.sol lines 54-56), and it also makes the TESTNET_FORK path point to a mainnet-only address.
Useful? React with 👍 / 👎.
📊 Forge Coverage ReportGenerated by workflow run #651 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes are confined to fork tests/helpers, but they alter which timelock address and executor are used when generating/executing timelock transactions, which could lead to incorrect onchain tx generation if misconfigured.
Overview
Adds new mainnet-fork timelock tests that (1) build and execute a real
EtherFiRestaker.completeQueuedWithdrawalscall and subsequentstEthRequestWithdrawal, and (2) schedule/execute a batch update onEtherFiRedemptionManagerto set 0 exit fee, increase capacity, and adjust refill rate, then simulate a large instant redemption flow.Updates forked
TestSetupto use a hardcodedEtherFiTimelockaddress and changes_batch_execute_timelockto pick the prank executor based on whether the configured timelock is the 3-day vs 8-hour timelock address.Written by Cursor Bugbot for commit 32cfb04. This will update automatically on new commits. Configure here.