Skip to content

Conversation

@BCsabaEngine
Copy link

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide
  5. Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

Related links

Please provide links to related issue, PRs etc.

...
Compiling .pio/build/default/lib7e0/WiFi/WiFiGeneric.cpp.o
Compiling .pio/build/default/lib7e0/WiFi/WiFiMulti.cpp.o
/Users/xxxxxxxx/.platformio/packages/framework-arduinoespressif32/libraries/WebServer/src/WebServer.cpp: In member function 'void WebServer::chunkResponseEnd()':
/Users/xxxxxxxx/.platformio/packages/framework-arduinoespressif32/libraries/WebServer/src/WebServer.cpp:616:23: warning: 'virtual void NetworkClient::flush()' is deprecated: Use clear() instead. [-Wdeprecated-declarations]
  616 |   _chunkedClient.flush();
      |   ~~~~~~~~~~~~~~~~~~~~^~
In file included from /Users/balazscsaba/.platformio/packages/framework-arduinoespressif32/libraries/Network/src/NetworkServer.h:23,
                 from /Users/balazscsaba/.platformio/packages/framework-arduinoespressif32/libraries/WebServer/src/WebServer.cpp:28:
/Users/xxxxxxxx/.platformio/packages/framework-arduinoespressif32/libraries/Network/src/NetworkClient.h:61:8: note: declared here
   61 |   void flush();  // Print::flush tx
      |        ^~~~~
Compiling .pio/build/default/lib7e0/WiFi/WiFiSTA.cpp.o
...

@BCsabaEngine BCsabaEngine requested a review from a team as a code owner November 2, 2025 13:20
@CLAassistant
Copy link

CLAassistant commented Nov 2, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello BCsabaEngine, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against a65c12d

@lucasssvaz lucasssvaz requested a review from me-no-dev November 2, 2025 13:55
@SuGlider SuGlider self-requested a review November 3, 2025 07:09
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants