Skip to content

fix/albedo system libs#917

Merged
mandresm merged 3 commits intoreleasefrom
fix/albedo_system_libs
Mar 23, 2023
Merged

fix/albedo system libs#917
mandresm merged 3 commits intoreleasefrom
fix/albedo_system_libs

Conversation

@mandresm
Copy link
Contributor

fix environment variables to use the system libs. Thanks to @sebhinck for spotting those!

@mandresm mandresm requested a review from pgierz March 15, 2023 09:23
Copy link
Member

@pgierz pgierz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And now comes....version 6.20.1 ;-) Thanks @sebhinck

@pgierz
Copy link
Member

pgierz commented Mar 15, 2023

Still need new changes in test "truth" to get passing CI. @mandresm, is the standard workflow for that documented somewhere and I am just too lazy to find it?

@mandresm
Copy link
Contributor Author

Still need new changes in test "truth" to get passing CI. @mandresm, is the standard workflow for that documented somewhere and I am just too lazy to find it?

https://esm-tools.readthedocs.io/en/latest/esm_tests.html#esm-tests-cookbook

@pgierz
Copy link
Member

pgierz commented Mar 15, 2023

Still need new changes in test "truth" to get passing CI. @mandresm, is the standard workflow for that documented somewhere and I am just too lazy to find it?

https://esm-tools.readthedocs.io/en/latest/esm_tests.html#esm-tests-cookbook

🤦🏻 ...thanks

@mandresm
Copy link
Contributor Author

#approve-changes

@mandresm
Copy link
Contributor Author

#bump

@mandresm mandresm merged commit 01179e9 into release Mar 23, 2023
@mandresm mandresm deleted the fix/albedo_system_libs branch March 23, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants