Script in 'preprocess' is not executed for oifsamip-cy48 simulations.

[nwieters]

Describe the bug
Running AMIP experiment with oifsamip-cy48 model. During prepcompute(?) the script 'change_icm_date.sh' that should be called via preprocess plugin is not running at all.
I am not sure whether the prepcompute recipe is not running or just the script not called. Will have a look at this also.
Plugin preprocess is installed (0.0.1.dev3).

To Reproduce
Steps to reproduce the behavior:
esm_tools branch: amip_cmip7
test runscript: /work/ab0995/a270089/myrunscripts/oifs_amip/oifsamip-cy48-levante-TCO95L91_CMIP7.yaml

Expected behavior
Running the script change_icm_date.sh during oifsamip initial experiment.

Screenshots

System (please complete the following information):

• Supercomputer: levante
• Version: esm_tools, version 6.60.2

Additional context

[nwieters]

Talked to @JanStreffing and @mandresm about it.

[nwieters]

Running esm_runscript in verbose mode shows, that the prepcompute_recipe is running but in the recipe, some steps that are prescribed in oifs.yaml are missing, such as write_env and preprocess.
I will check where this prepcompute_recipe is finally set for oifsamip-cy48.

[nwieters]

I think it is running the default recipe for prepcompute with 16 steps.

[JanStreffing]

Ah, so we were missing a piece of configuration in the oifsamip setup file?

[nwieters]

Yes. As in setup->awiesm3.yaml, the recipes are loaded from oifs.yaml. And this was missing for the prepcompute recipe in the setup config of oifsamip.yaml.
I will fix this. I might also need to add other recipes such as tidy.

[mandresm]

Hi there! Sorry for the delay, I have missed the issue completely. I'll have a look at it asap.

[mandresm]

Yes. As in setup->awiesm3.yaml, the recipes are loaded from oifs.yaml. And this was missing for the prepcompute recipe in the setup config of oifsamip.yaml.
I will fix this. I might also need to add other recipes such as tidy.

Good catch @nwieters! I get it now... recipes need to be in general at least for setups... Since we now have sections even in the component yamls I suggest you move the prepcompute_recipe (and any recipe there) into a new general section in oifs.yaml. Then you should not need it in the awicm3.yaml or the oifsamip.yaml. I recommend you try it and keep it that way if it works :)

+general:
    prepcompute_recipe:
       - "compile_model"
       - "_show_simulation_info"
       - "create_new_files"
       - "create_empty_folders"
       - "prepare_coupler_files"
       - "assemble"
       - "log_used_files"
       - "_write_finalized_config"
       - "wait_for_iterative_coupling"
       - "copy_files_to_thisrun"
       - "write_env"
       - "preprocess"
       - "modify_namelists"
       - "modify_files"
       - "copy_files_to_work"
       - "report_missing_files"
       - "compute_and_log_file_checksums"
       # see https://github.com/esm-tools/esm_tools/discussions/774
       # - "add_vcs_info"
       #- "check_vcs_info_against_last_run"
       - "database_entry"
    # this does not work as expected, solution is work in progress
    #   - "postprocess"