Use enif_alloc/enif_free for std::vector allocations#79
Open
NelsonVides wants to merge 1 commit intomasterfrom
Open
Use enif_alloc/enif_free for std::vector allocations#79NelsonVides wants to merge 1 commit intomasterfrom
NelsonVides wants to merge 1 commit intomasterfrom
Conversation
std::vector's default std::allocator uses malloc/free, which bypasses BEAM memory bookkeeping. Introduce a custom enif_allocator<T> that delegates to enif_alloc/enif_free so all NIF heap usage is visible to erlang:memory() and crash dumps.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #79 +/- ##
==========================================
- Coverage 74.01% 73.99% -0.02%
==========================================
Files 7 7
Lines 1189 1196 +7
Branches 169 171 +2
==========================================
+ Hits 880 885 +5
- Misses 309 311 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::vector's defaultstd::allocatoruses malloc/free, which bypasses BEAM memory bookkeeping. Introduce a customenif_allocator<T>that delegates toenif_alloc/enif_freeso all NIF heap usage is visible toerlang:memory()and crash dumps.Not sure who's the ideal reviewer for this so tagging a couple of guys 😉