fix City bike helsinki #848
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Digitransit has long deprecated the routing v1 API. The new endpoint uses otp v2, and the routing endpoint uses graphql.
https://digitransit.fi/en/developers/apis/1-routing-api/
There's one endpoint for the whole Finland + Estonia, and then there's separate endpoints for HSL, south west finland and Waltti cities.
There's both a resource for querying by a bbox and one without. Code clarity wise the implementation without bbox and doing the bbox filtering on our side is much clearer so we are going with that. We can potentially move it to use the separate feeds.
Changes