[pull] main from triggerdotdev:main #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Background** Currently the changeset PR creation and the publishing is handled by the same workflow. This is not ideal: - The build steps are executed on every run of the pipeline, even though they're only needed for the publish case. - The PR creation workflow does not need permissions to publish to npm, only the release path needs them. - Adding an approval step is painful as we'd need to also approve each changeset PR creation workflow run. **Changes in this PR** - Separated the changeset PR creation into its own workflow and minimum permission set. - Added a GH environment with an approval step for the package publishing workflow (also for prereleases). - New publish workflow runs will not cancel in-progress runs; helps avoid partial failures in publishing. These changes also enable hardening the npm OIDC setup by tying it to a GH environment that requires approval.
Just a tiny workflow label change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )