Replaced combined virtual host with SSL-only virtual host #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to keep it simpler and easier to maintain and modify
…simple-installation # Conflicts: # docker-compose.simple-install.yml
which will get compatibility with eramba images soon to prevent HTTP_HOST security header issue
…l-virtual-host-by-default-with-simple-installation
elsombrante
approved these changes
Nov 2, 2022
elsombrante
deleted the
27-use-only-ssl-virtual-host-by-default-with-simple-installation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vhost-with-ssh.confhas been renamed tovhost-ssl.confand kept in version that contains only 443 SSL virtual host.Also, simple install now mounts
vhost-ssl.confby default, which is accessible athttps://localhost:8443. There is no redirection fromhttp://localhost:8080tohttps://localhost:8443anymore. This can be easily customized on-demand.This was done to keep it more simpler and easier to maintain and modify.
Also this PR introduces new env() value
PUBLIC_ADDRESSwhich will start having effect in upcoming eramba versions. That is to avoid using only HTTP_HOST env() value which can result in security issues with header attack.