Push finalized checkpoint transcripts on turn-end by khaong · Pull Request #636 · entireio/cli

khaong · 2026-03-06T10:27:29Z

Summary

When an agent commits and pushes during a turn, PrePush now marks ACTIVE sessions with TurnCheckpointIDs by setting PushedDuringTurnRemote on session state
HandleTurnEnd checks this flag after finalizing transcripts and pushes entire/checkpoints/v1 to the same remote
Flag is cleared on turn-end (after push attempt) and on new turn start (InitializeSession)

Closes the gap where the remote had a provisional transcript after a mid-turn push, but the finalized version (with trailing conversation) stayed local.

Design doc

docs/plans/2026-03-06-turn-end-checkpoint-push-design.md (in worktree, not committed — contains full analysis of multi-session scenarios and known limitations)

Known limitation

In the concurrent multi-session edge case where a session has both pushed and unpushed checkpoints, the turn-end push will push the entire entire/checkpoints/v1 branch — including metadata for unpushed code commits. This is rare and can be addressed with future checkpoint GC.

Test plan

🤖 Generated with Claude Code

When an agent commits and pushes during a turn, the remote checkpoint contains a provisional transcript. HandleTurnEnd finalizes it with the complete conversation but previously didn't push the update, leaving the remote stale. Now PrePush marks ACTIVE sessions with TurnCheckpointIDs by setting PushedDuringTurnRemote on their state. HandleTurnEnd checks this flag after finalizing transcripts and pushes entire/checkpoints/v1 to the same remote, keeping the remote consistent. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Entire-Checkpoint: 738ef53b2521

cursor · 2026-03-06T10:27:35Z

PR Summary

Medium Risk
Adds new state tracking and additional git push behavior in PrePush/HandleTurnEnd, which could affect when checkpoint metadata is published to remotes (especially in multi-session/concurrent scenarios). Changes are best-effort and well-covered by new unit/integration/e2e tests, reducing but not eliminating behavioral risk.

Overview
Ensures checkpoint transcripts on entire/checkpoints/v1 stay consistent on the remote when a push happens mid-turn by introducing a per-session PushedDuringTurnRemote flag.

PrePush now marks ACTIVE sessions with TurnCheckpointIDs as having pushed to a specific remote, and HandleTurnEnd uses that flag to (best-effort) push the finalized checkpoint transcripts to the same remote after finalization, then clears the flag (also cleared on new prompt start).

Adds coverage for the flag lifecycle and turn-end push behavior via new unit tests, integration tests, and an e2e canary flow (including extending the Vogon prompt parser/executor to support push).

^{Written by Cursor Bugbot for commit aca417a. Configure here.}

cmd/entire/cli/strategy/manual_commit_push.go

Copilot

Pull request overview

This PR adds a “turn-end push” mechanism to ensure that when checkpoints are pushed mid-turn (with provisional transcripts), the finalized checkpoint transcripts are also pushed at turn end to keep the remote metadata consistent.

Changes:

Track mid-turn remote pushes via a new session-state flag (PushedDuringTurnRemote) set during PrePush.
On HandleTurnEnd, finalize transcripts and (if flagged) best-effort push the checkpoints metadata branch to the same remote, then clear the flag.
Add unit + integration coverage for flag marking/clearing and turn-end push behavior; deduplicate test transcript fixtures.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
cmd/entire/cli/strategy/phase_postcommit_test.go	Adds unit tests covering turn-end push behavior (flagged vs unflagged).
cmd/entire/cli/strategy/manual_commit_test.go	Adds unit test ensuring `InitializeSession` clears the new push flag.
cmd/entire/cli/strategy/manual_commit_push_test.go	New unit tests for `markActiveSessionsPushed` behavior across phases / checkpoint presence.
cmd/entire/cli/strategy/manual_commit_push.go	Marks ACTIVE sessions as “pushed during turn” after checkpoint-branch push in `PrePush`.
cmd/entire/cli/strategy/manual_commit_hooks.go	Implements best-effort turn-end push when `PushedDuringTurnRemote` is set; clears the flag.
cmd/entire/cli/strategy/common_test.go	Introduces shared minimal transcript constant to satisfy `goconst`.
cmd/entire/cli/session/state.go	Adds `PushedDuringTurnRemote` to persisted session state with lifecycle documentation.
cmd/entire/cli/integration_test/turn_end_push_test.go	New integration tests validating full lifecycle and stale-flag clearing on new prompt.
CLAUDE.md	Documents the new turn-end push behavior and key file locations.

cmd/entire/cli/strategy/manual_commit_push.go

cmd/entire/cli/strategy/manual_commit_hooks.go

- Remove unreachable error branches in pushFinalizedCheckpointsIfNeeded (doPushBranch always returns nil, handling errors internally via stderr) - Add multi-session test for markActiveSessionsPushed verifying all ACTIVE sessions get marked while IDLE sessions are skipped Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Entire-Checkpoint: 80c2d8b615c0

…ls push - Only mark sessions as pushed when push_sessions is not disabled, preventing incorrect flag state when pushing is off - Remove trails push from pushFinalizedCheckpointsIfNeeded — trails have a different lifecycle and don't need to be coupled here Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Entire-Checkpoint: 67f4c6e88c77

- Add push support to Vogon agent (regex parsing + git push execution) - Add 3 E2E tests: - Manual push triggers pre-push hook, checkpoints arrive at remote - Mid-turn push + turn-end pushes finalized transcripts (agent-agnostic) - No push during turn = no remote checkpoint advancement Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Entire-Checkpoint: 37bb6a89bb73

khaong · 2026-03-06T11:28:29Z

bugbot run

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

e2e/vogon/main.go

cmd/entire/cli/strategy/manual_commit_hooks.go

- Remove `continue` after commit in parseNumberedSteps so push check runs on combined steps like "(2) commit and push" - Add comment on pushBranchIfNeeded error check explaining it's defensive (currently always returns nil but kept for correctness if that changes) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Entire-Checkpoint: 7f7c3a582840

…s-remote-checkpoints # Conflicts: # cmd/entire/cli/strategy/manual_commit_test.go

…eckpoints' into alex/stop-hook-updates-remote-checkpoints

Entire-Checkpoint: ebaa181741e1

Copilot AI review requested due to automatic review settings March 6, 2026 10:27

Copilot started reviewing on behalf of khaong March 6, 2026 10:28 View session

cursor bot reviewed Mar 6, 2026

View reviewed changes

cmd/entire/cli/strategy/manual_commit_push.go Outdated Show resolved Hide resolved

Copilot AI reviewed Mar 6, 2026

View reviewed changes

cmd/entire/cli/strategy/manual_commit_push.go Show resolved Hide resolved

cmd/entire/cli/strategy/manual_commit_hooks.go Outdated Show resolved Hide resolved

khaong and others added 4 commits March 6, 2026 21:54

Merge branch 'main' into alex/stop-hook-updates-remote-checkpoints

38ec39a

khaong requested a review from Copilot March 6, 2026 11:28

Copilot started reviewing on behalf of khaong March 6, 2026 11:29 View session

cursor bot reviewed Mar 6, 2026

View reviewed changes

Copilot AI reviewed Mar 6, 2026

View reviewed changes

e2e/vogon/main.go Show resolved Hide resolved

cmd/entire/cli/strategy/manual_commit_hooks.go Show resolved Hide resolved

khaong and others added 2 commits March 6, 2026 22:37

Merge branch 'main' into alex/stop-hook-updates-remote-checkpoints

ba95d85

khaong marked this pull request as ready for review March 6, 2026 11:53

khaong requested a review from a team as a code owner March 6, 2026 11:53

khaong added 4 commits March 6, 2026 23:12

Merge branch 'main' into alex/stop-hook-updates-remote-checkpoints

46a08f9

Merge remote-tracking branch 'origin/main' into alex/stop-hook-update…

5dec0e6

…s-remote-checkpoints # Conflicts: # cmd/entire/cli/strategy/manual_commit_test.go

Merge remote-tracking branch 'origin/alex/stop-hook-updates-remote-ch…

bdb03dc

…eckpoints' into alex/stop-hook-updates-remote-checkpoints

Fix gofmt alignment after merge

33dd6dc

Entire-Checkpoint: ebaa181741e1

jcleira mentioned this pull request Mar 7, 2026

Push finalized checkpoint transcripts to remote on turn end partio-io/minions#39

Open

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Push finalized checkpoint transcripts on turn-end#636

Push finalized checkpoint transcripts on turn-end#636
khaong wants to merge 11 commits intomainfrom
alex/stop-hook-updates-remote-checkpoints

khaong commented Mar 6, 2026 •

edited

Loading

Uh oh!

cursor bot commented Mar 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

khaong commented Mar 6, 2026

Uh oh!

cursor bot left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

khaong commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Design doc

Known limitation

Test plan

Uh oh!

cursor bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

khaong commented Mar 6, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

khaong commented Mar 6, 2026 •

edited

Loading

cursor bot commented Mar 6, 2026 •

edited

Loading