[mob][photos] Add iOS upload grace window and bg handoff#9810
[mob][photos] Add iOS upload grace window and bg handoff#9810prateekmedia wants to merge 14 commits intoprtk/bg-patchesfrom
Conversation
![chatgpt-codex-connector[bot]](https://waps.l3s.uni-hannover.de/live/im_/https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 177b70a08e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
mobile/apps/photos/lib/services/upload_background_coordinator.dart
Outdated
Show resolved
Hide resolved
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e45da7d34d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
mobile/apps/photos/lib/services/upload_background_coordinator.dart
Outdated
Show resolved
Hide resolved
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c6787d841
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d60d117ed7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| final expired = await GraceWindowIos.awaitExpiration(); | ||
| if (!expired) { |
There was a problem hiding this comment.
This flow relies on awaitExpiration() resolving to enqueue the BGProcessing continuation task, but the comment already notes delivery can be missed when the process is suspended. In that case this await never resumes, so scheduleIOSBackgroundProcessingTask(...) is never called and active uploads can remain stranded in background until the app is foregrounded again (or a later periodic trigger happens). Please add a fallback path that does not depend solely on this pending MethodChannel reply (for example, durable scheduling on grace-window start or native-side expiry handling).
Useful? React with 👍 / 👎.
1 participant
Description
Allow operations to run for a short interval in background using grace window.
Tests