Add icon-bg and icon-fg to fix_args#6
Merged
dbnicholson merged 1 commit intomulti_arch_webview_updatesfrom Jul 7, 2022
Merged
Conversation
Fix the icon-bg and icon-fg arguments and also create the folder mipmap-anydpi-v26 if it doesn't exists before trying to create a file inside. https://phabricator.endlessm.com/T33593
dbnicholson
approved these changes
Jul 6, 2022
Member
dbnicholson
left a comment
dbnicholson
left a comment
There was a problem hiding this comment.
That looks appropriate. I suspect this is one of those things where buildozer does this kind of prep for you and upstream doesn't notice it's broken in p4a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the icon-bg and icon-fg arguments and also create the folder
mipmap-anydpi-v26 if it doesn't exists before trying to create a file
inside.
https://phabricator.endlessm.com/T33593