Skip to content

remove conditions and allow all flags #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xcho1 wants to merge 1 commit into from
Closed

remove conditions and allow all flags #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pythonforandroid/bootstraps/webview/build/templates/AndroidManifest.tmpl.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@

<activity android:name="org.kivy.android.PythonActivity"
android:label="@string/app_name"
android:configChanges="mcc|mnc|locale|touchscreen|keyboard|keyboardHidden|navigation|orientation|screenLayout|fontScale|uiMode{% if args.min_sdk_version >= 8 %}|uiMode{% endif %}{% if args.min_sdk_version >= 13 %}|screenSize|smallestScreenSize{% endif %}{% if args.min_sdk_version >= 17 %}|layoutDirection{% endif %}{% if args.min_sdk_version >= 24 %}|density{% endif %}"
android:configChanges="mcc|mnc|locale|touchscreen|keyboard|keyboardHidden|navigation|orientation|screenLayout|fontScale|uiMode|screenSize|smallestScreenSize|layoutDirection|density"
Copy link

@manuq manuq Oct 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current conditionals are for the minimum SDK supported. In the .p4a configuration file we currently have:

--minsdk 21

So the only conditional that currently doesn't apply is density:

{% if args.min_sdk_version >= 24 %}|density{% endif %}

From docs https://developer.android.com/guide/topics/manifest/activity-element density was "Added in API level 24". So it seems right to keep the conditional in the template. We should instead bump our minimum SDK. SDK 21 is Android 5 which is way too old. I think we should bump to min SDK to 24.

Copy link
Author

@xcho1 xcho1 Oct 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it's safe to bump to SDK 24, but then the condition is alwyas true, so potentialy could be removed as well

Copy link

@manuq manuq Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because the upstream template should still work with older SDKs for other projects. Ideally we are going to get rid of this fork and use upstream p4a. The only reason we have p4a forked is because we have PRs upstream that are still open.

android:screenOrientation="{{ args.orientation }}"
android:exported="true"
{% if args.activity_launch_mode %}
Expand Down