Avoid asserting in glReadPixels for unsupported types, return GL_INVALID_ENUM instead#2603
Closed
JasonGreen wants to merge 1 commit intoemscripten-core:incomingfrom
Closed
Avoid asserting in glReadPixels for unsupported types, return GL_INVALID_ENUM instead#2603JasonGreen wants to merge 1 commit intoemscripten-core:incomingfrom
JasonGreen wants to merge 1 commit intoemscripten-core:incomingfrom
Conversation
JasonGreen
changed the title
src/library_gl.js
Outdated
Collaborator
There was a problem hiding this comment.
{ should go on the same line with the if.
…VALID_ENUM instead
Contributor
Author
|
Updated to conform with coding style |
Collaborator
|
Hey, revisiting this, I realize that I want to handle this a bit differently instead, that is forward-compatible with WebGL 2 and further. I pushed in this commit: 0d214a1 . I'll close this pull request, but let me know if something is off in that commit! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should never assert in any GL code.