Skip to content

CI: Enable Ember v4 scenarios again#740

Merged
Turbo87 merged 1 commit intoember-cli:masterfrom
Turbo87:ember-4
Dec 11, 2021
Merged

CI: Enable Ember v4 scenarios again#740
Turbo87 merged 1 commit intoember-cli:masterfrom
Turbo87:ember-4

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 21, 2021

#739 should have fixed the issue.

@Turbo87
Copy link
Member Author

Turbo87 commented Oct 21, 2021

well... looks like liquid-fire is still giving us trouble 🙈

@SergeAstapov
Copy link
Contributor

SergeAstapov commented Oct 21, 2021

@Turbo87 this got fixed in #726 😜

EDIT: there is smaller PR #747 which the minimum amount of changes needed to make CI pass.

@SergeAstapov
Copy link
Contributor

Update:
#746 and #747 need to land first as they update transitive dependencies that causes failures in this PR.

@Turbo87 Turbo87 merged commit c0568fb into ember-cli:master Dec 11, 2021
@Turbo87 Turbo87 deleted the ember-4 branch December 11, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants