Merged
Conversation
NullVoxPopuli
force-pushed
the
nvp/vite-support
branch
from
12a7aae to
4c63fef
Compare
This was referenced Jul 23, 2025
NullVoxPopuli
force-pushed
the
nvp/vite-support
branch
from
92d464c to
c50e6f7
Compare
|
This all makes sense to me. I also eventually realised I needed to make the fns async, but I neglected to update my comments with the code (didn't want to add more unnecessary detail). Much better approach than what I had, and looks backwards compatible with pre-vite setups. I couldn't figure out a sensible way to do that. Nice work ✌️ Is the failing test an easy fix? |
NullVoxPopuli
force-pushed
the
nvp/vite-support
branch
2 times, most recently
from
56860ec to
cd4b4e5
Compare
NullVoxPopuli
force-pushed
the
nvp/vite-support
branch
3 times, most recently
from
b485ad1 to
9dfb60a
Compare
NullVoxPopuli
force-pushed
the
nvp/vite-support
branch
2 times, most recently
from
9d8dd13 to
0f5e20c
Compare
Add test for split + partition and vite Ignore test-execution json files Support testem.cjs config files Don't eagerly load modules during the load-balance branch DEBUG/LOG - REVERT THIS Formatting --load-balance test Update deps Don't use the OnerrorValidation -- results in erroring when there are no tests to run for a browser Formatting Lockfile ope Re-arrange CI a bit Update tests Rename workflow Fix base vite test Cleanup
… it's supposed to launch browsers simultaneously, instead of one after the other
NullVoxPopuli
force-pushed
the
nvp/vite-support
branch
from
2ddf424 to
a7a7878
Compare
mansona
approved these changes
Aug 26, 2025
Member
mansona
left a comment
mansona
left a comment
There was a problem hiding this comment.
This looks good, I'm happy with the tests so it's at least a viable thing for a release 👍 There might be some edge cases that show up in the ecosystem but I think we should release this and fix-forward 💪
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: #1431 (else diff will be too big)Edit: mergedApplies some changes from: #1387
This might be a breaking change because:
start()has to beasyncnow (for vite only, and only when passing import.meta.glob (no eager asavailableModules) -- this is so we don't load all test modules for every partition - but prior users won't notice.Existing users of ember-exam (broccoli, webpack) hopefully won't be disrupted, and they don't need to change their
startto be awaited (and this is true of vite as well -- we don't need to await the start function)Important
One weird thing about using the
ember examcommand with vite is that the output folder must not be named anything other thandist.ember-cli(and the tooling team) agree that this restriction is a bug, andember test(as well!) /ember examshould be able to handle--paths other thandist