Update setup example for new qunit requirements#1347
Merged
NullVoxPopuli merged 1 commit intoember-cli:mainfrom Mar 14, 2025
Merged
Update setup example for new qunit requirements#1347NullVoxPopuli merged 1 commit intoember-cli:mainfrom
NullVoxPopuli merged 1 commit intoember-cli:mainfrom
Conversation
`setupEmberOnerrorValidation` was added to the Vite setup instructions in ember-cli#1313 but missed for the normal setup guide. This is required as of ember-qunit v9, I believe.
Contributor
|
It's not required, exactly but new apps would otherwise have 0 test, and then have failing tests out of the box (qunit requires an least one test) |
NullVoxPopuli
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setupEmberOnerrorValidationwas added to the Vite setup instructions in #1313 but missed for the normal setup guide. This is required as of ember-qunit v9, I believe.