first take on per-test qunit splitting#119
first take on per-test qunit splitting#119mariokostelac wants to merge 1 commit intoember-cli:mainfrom
Conversation
This is an example of how we could support per-test test splitting for qunit. I would like to get feedback on the approach and whether it has some future so I could continue working on it. It breaks mocha so I am interested in thoughts on that as well.
|
Just to note, I am willing to work on getting it done for Mocha as well if this approach is ok with you. |
trentmwillis
left a comment
trentmwillis
left a comment
There was a problem hiding this comment.
Thanks for working on this! I won’t be able to get to this this week due to travel, but definitely want to review when I get back. This would be an awesome feature to have!
|
No problem, thanks for taking time to comment :). Looking forward to make it work for everybody. |
trentmwillis
left a comment
trentmwillis
left a comment
There was a problem hiding this comment.
Overall, seems like a reasonable approach. However, I'd like to ensure we maintain support for both QUnit and Mocha and the current implementation looks pretty tightly coupled to QUnit. So, there will likely need to be some sort of framework detection.
If you can get the tests passing, I'll do a more thorough review.
|
I will try to get them passing next week. It is possible I will need a little bit of help. If that happens, will communicate through comments here. |
2 participants
This is an example of how we could support per-test test splitting for
qunit. I would like to get feedback on the approach and whether it has
some future so I could continue working on it.
It breaks mocha so I am interested in thoughts on that as well.
Tests failing: unit tests of TestLoader.