Fix issues causing it to be impossible to use certain workspace config options with eglot#117
Open
lolbinarycat wants to merge 2 commits intoemacs-rustic:mainfrom
Open
Fix issues causing it to be impossible to use certain workspace config options with eglot#117lolbinarycat wants to merge 2 commits intoemacs-rustic:mainfrom
lolbinarycat wants to merge 2 commits intoemacs-rustic:mainfrom
Conversation
this allows user customization and similar.
otherwise some config options won't function properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust-analyzer recommends passing the "rust-analyzer" section of the workspace config as
initializationOptions, as it needs to know the values of certain options during initialization.rustic was not only not doing this, it was actually making this basically impossible to do by unconditionally overriding
eglot-initialization-optionsto an implementation that ignored the user-specified initialization options.fixes #105