Skip to content

Comments

Add a GitHub Action workflow for tests and formatting#173

Merged
harrysarson merged 1 commit intoelm-explorations:masterfrom
mpizenberg:gh-action
Sep 10, 2021
Merged

Add a GitHub Action workflow for tests and formatting#173
harrysarson merged 1 commit intoelm-explorations:masterfrom
mpizenberg:gh-action

Conversation

@mpizenberg
Copy link
Contributor

No description provided.

@mpizenberg
Copy link
Contributor Author

This will probably need an action (pun intended) on your part @harrysarson to activate the GH action. This may not work on the first shot so maybe tweaks will be needed too since I can't easily test the action setup.

@harrysarson
Copy link
Collaborator

do you know how I activate it?

@mpizenberg
Copy link
Contributor Author

No idea sorry. It always was active for my projects by just creating the workflow files. And one time someone new contributed to a project of mine and I had to click on "run action" or something similar because it was the first time they contributed to the repo, but the action was already setup. So for Action setup I don't know. Maybe requires something by someone who owns elm-explorations?

@avh4
Copy link
Collaborator

avh4 commented Sep 8, 2021

The actions config is always a bit confusing to me... Note also that depending on the settings, there can be differences in which actions it runs based on who that branch author is and whether it's a PR or not.

I think the relevant settings are at Settings -> Actions, and check that both the "Actions permissions" section and "Fork pull request workflows from outside collaborators" seem to have settings that make sense.

@mpizenberg
Copy link
Contributor Author

@harrysarson did you find the relevant settings? who should we ask otherwise that has the rights to make changes?

@harrysarson harrysarson merged commit a5fa136 into elm-explorations:master Sep 10, 2021
@harrysarson
Copy link
Collaborator

I tried merging, we can always fix it in a future mr

@mpizenberg mpizenberg deleted the gh-action branch September 11, 2021 00:20
@mpizenberg
Copy link
Contributor Author

Well at least checking formatting worked ^^ https://github.com/elm-explorations/test/runs/3571514113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants