feat: support full-page screenshots#827
Open
afomi wants to merge 1 commit intoelixir-wallaby:mainfrom
Open
Conversation
afomi
commented
Nov 12, 2025
afomi
commented
- for ChromeDriver and GeckoDriver
* for ChromeDriver and GeckoDriver
afomi
changed the title
mhanberg
reviewed
Nov 13, 2025
| assert_file_exists(path) | ||
|
|
||
| # Verify the file is a valid PNG by checking the PNG signature | ||
| {:ok, file_content} = File.read(path) |
Member
There was a problem hiding this comment.
I would just use File.read! here, so if it fails, it fails with the right error and not a match error.
| ensure_setting_is_reset(:wallaby, :screenshot_dir) | ||
| Application.put_env(:wallaby, :screenshot_dir, screenshots_path) | ||
|
|
||
| [path] = |
Member
There was a problem hiding this comment.
Suggested change
| [path] = | |
| assert [path] = |
|
|
||
| # Verify the file is a valid PNG by checking the PNG signature | ||
| {:ok, file_content} = File.read(path) | ||
| <<0x89, 0x50, 0x4E, 0x47, 0x0D, 0x0A, 0x1A, 0x0A, _rest::binary>> = file_content |
Member
There was a problem hiding this comment.
Suggested change
| <<0x89, 0x50, 0x4E, 0x47, 0x0D, 0x0A, 0x1A, 0x0A, _rest::binary>> = file_content | |
| assert <<0x89, 0x50, 0x4E, 0x47, 0x0D, 0x0A, 0x1A, 0x0A, _rest::binary>> = file_content |
| Application.put_env(:wallaby, :screenshot_dir, screenshots_path) | ||
|
|
||
| # Both of these should work the same way (viewport screenshot) | ||
| [path1] = page |> take_screenshot(name: "test1") |> Map.get(:screenshots) |
Member
There was a problem hiding this comment.
Suggested change
| [path1] = page |> take_screenshot(name: "test1") |> Map.get(:screenshots) | |
| assert [path1] = page |> take_screenshot(name: "test1") |> Map.get(:screenshots) |
|
|
||
| # Both of these should work the same way (viewport screenshot) | ||
| [path1] = page |> take_screenshot(name: "test1") |> Map.get(:screenshots) | ||
| [path2] = page |> take_screenshot(name: "test2", full_page: false) |> Map.get(:screenshots) |
Member
There was a problem hiding this comment.
Suggested change
| [path2] = page |> take_screenshot(name: "test2", full_page: false) |> Map.get(:screenshots) | |
| assert [path2] = page |> take_screenshot(name: "test2", full_page: false) |> Map.get(:screenshots) |
Comment on lines
+235
to
+236
| - Chrome: Uses Chrome DevTools Protocol (CDP) for native fullpage capture | ||
| - Firefox: Uses GeckoDriver's Moz-specific fullpage screenshot endpoint |
Member
There was a problem hiding this comment.
Is this information relevant? I feel like implies to the user that they should know how these things work, but the respective webdriver takes care of it.
Member
There was a problem hiding this comment.
It might be useful to indicate which versions of the webdriver that supports this functionality
|
|
||
| @doc false | ||
| def take_fullpage_screenshot(session_or_element) do | ||
| WebdriverClient.take_fullpage_screenshot_moz(session_or_element) |
Member
There was a problem hiding this comment.
So, selenium is not only used for Firefox. You can use it with any browser/web driver it supports. I think this code won't work if you use selenium with chrome.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.