Remove impossible clause on DateTime.from_naive!/2 #8080
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Good catch! I believe this will no longer be true once #7914 will be merged, so I think we should just wait until it is merged. Thanks! |
fertapric
deleted the
fertapric-remove-unused-code-on-datetime-from-naive-bang-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
DateTime.from_naive/2always returns{:ok, datetime}.Other option is to update
DateTime.from_naive/2to include a fallback clause that returns errors. For example,{:error, :unsupported_time_zone}when thetime_zoneattribute is not "Etc/UTC".